Fix race conditions where an object's constructor uses PostTask on itself. T...

base/task.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TASK_H_
 #define BASE_TASK_H_
 
 #include "base/non_thread_safe.h"
 #include "base/tracked.h"
 #include "base/tuple.h"
@@ skipping 203 matching lines @@
   ~RunnableMethodTraits() {
 #ifndef NDEBUG
     // If destroyed on a separate thread, then we had better have been using
     // thread-safe reference counting!
     if (origin_thread_id_ != PlatformThread::CurrentId())
       DCHECK(T::ImplementsThreadSafeReferenceCounting());
 #endif
   }
 
   void RetainCallee(T* obj) {
+#ifndef NDEBUG
+    // Catch NewRunnableMethod being called in an object's constructor.  This
+    // isn't safe since the method can be invoked before the constructor
+    // completes, causing the object to be deleted.
+    obj->AddRef();
+    obj->Release();
+#endif
     obj->AddRef();
   }
 
   void ReleaseCallee(T* obj) {
     obj->Release();
   }
 
  private:
 #ifndef NDEBUG
   PlatformThreadId origin_thread_id_;
@@ skipping 434 matching lines @@
 
 template <class T, typename ReturnValue>
 typename CallbackWithReturnValue<ReturnValue>::Type*
 NewCallbackWithReturnValue(T* object, ReturnValue (T::*method)()) {
   return new CallbackWithReturnValueImpl<T, ReturnValue (T::*)(), ReturnValue>(
       object, method);
 }
 
 
 #endif  // BASE_TASK_H_