Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 3990005: Displays latest INIT_PROXY_RESOLVER log on the #proxy tab (Closed)

Created:
10 years, 2 months ago by mmenke
Modified:
9 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org
Visibility:
Public.

Description

Displays the most recent INIT_PROXY_RESOLVER source's log entries on the #proxy net-internals tab. Also adds a link to the #proxy tab to show all INIT_PROXY_RESOLVER events on the #events tab. BUG=56430 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63773

Patch Set 1 : '' #

Total comments: 4

Patch Set 2 : Addresses comments #

Patch Set 3 : Minor cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -2 lines) Patch
M chrome/browser/resources/net_internals/index.html View 1 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/resources/net_internals/main.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/net_internals/proxyview.js View 1 2 4 chunks +46 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
mmenke
Somewhat redundant, but think both can be helpful. Having the results and the log on ...
10 years, 2 months ago (2010-10-22 15:44:52 UTC) #1
eroman
lgtm http://codereview.chromium.org/3990005/diff/4001/5001 File chrome/browser/resources/net_internals/index.html (right): http://codereview.chromium.org/3990005/diff/4001/5001#newcode86 chrome/browser/resources/net_internals/index.html:86: <h4>Proxy resolver events</h4> Suggestions: (1) I suggest moving ...
10 years, 2 months ago (2010-10-22 21:21:44 UTC) #2
mmenke
http://codereview.chromium.org/3990005/diff/4001/5001 File chrome/browser/resources/net_internals/index.html (right): http://codereview.chromium.org/3990005/diff/4001/5001#newcode86 chrome/browser/resources/net_internals/index.html:86: <h4>Proxy resolver events</h4> On 2010/10/22 21:21:44, eroman wrote: > ...
10 years, 1 month ago (2010-10-25 14:50:44 UTC) #3
eroman
10 years, 1 month ago (2010-10-25 19:51:56 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698