Issue 3989004: Gzip using the fastest option.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3989004: Gzip using the fastest option. (Closed)

Created:
10 years, 2 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Gzip using the fastest option. Change-Id: Id75e54879e896e42ef69659fc602f625858fd33f BUG= TEST= Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4a6e482

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	bin/cbuildbot.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sosa

Gzip is just an optimization. Since the image is so big, let's use --fast for ...

10 years, 2 months ago (2010-10-23 00:15:42 UTC) #1

kmixter1

10 years, 2 months ago (2010-10-23 00:21:43 UTC) #2

LGTM

On Fri, Oct 22, 2010 at 5:15 PM,  <sosa@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Message:
> Gzip is just an optimization.  Since the image is so big, let's use --fast
> for
> more speed (right now it takes 1/4 of the pfq total time).
>
> Description:
> Gzip using the fastest option.
>
> Change-Id: Id75e54879e896e42ef69659fc602f625858fd33f
>
> BUG=
> TEST=
>
> Please review this at http://codereview.chromium.org/3989004/show
>
> SVN Base: http://git.chromium.org/git/crosutils.git
>
> Affected files:
>  M bin/cbuildbot.py
>
>
> Index: bin/cbuildbot.py
> diff --git a/bin/cbuildbot.py b/bin/cbuildbot.py
> index
>
ea082b651a8bb27b859d3afcf4a4e3de5e2755ab..721dd7057353eb568c6f811f92316407614f7935
> 100755
> --- a/bin/cbuildbot.py
> +++ b/bin/cbuildbot.py
> @@ -426,7 +426,7 @@ def _ArchiveTestResults(buildroot, board, archive_dir,
> test_results_dir):
>   image_name = 'chromiumos_qemu_image.bin'
>   image_path = os.path.join(buildroot, 'src', 'build', 'images', board,
>                             'latest', image_name)
> -  RunCommand(['gzip', '-f', image_path])
> +  RunCommand(['gzip', '-f', '--fast', image_path])
>   shutil.copyfile(image_path + '.gz', os.path.join(archive_target,
>                                                    image_name + '.gz'))
>
>
>
>

Expand Messages | Collapse Messages