Issue 3989001: Remove object files that somehow got committed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3989001: Remove object files that somehow got committed. (Closed)

Created:
10 years, 2 months ago by Luigi Semenzato

Modified:
9 years, 7 months ago

Reviewers:
Nick Sanders, Kenneth Waters

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/tpm.git

Visibility:
Public.

Description

Remove object files that somehow got committed. More cleanup. Change-Id: Ie32cd4a8196c225e627e19da5066599ae192f656 I don't know how these got committed. Very sorry. Change-Id: Ie4f1c768bfa369dcf1e9367c4620a0898ca72d0d BUG=none TEST=none Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=1814ad7

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+-4 lines, -113 lines)			Patch
D	nvtool/help/help.h	View	1 chunk	+0 lines, -101 lines	0 comments	Download
D	nvtool/main.d	View	1 chunk	+0 lines, -8 lines	0 comments	Download
	nvtool/main.o	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	nvtool/tpm-nvtool	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	nvtool/tpm_nv.d	View	1 chunk	+0 lines, -5 lines	0 comments	Download
	nvtool/tpm_nv.o	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	nvtool/tpm_nv_common.d	View	1 chunk	+0 lines, -3 lines	0 comments	Download
	nvtool/tpm_nv_common.o	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

My bad. Not sure how I could possibly commit object files. On 2010/10/20 21:24:14, Luigi ...

10 years, 2 months ago (2010-10-20 21:25:44 UTC) #2

Luigi Semenzato

Oh wait. Those files were there from the original commit! Maybe we just got lucky ...

10 years, 2 months ago (2010-10-20 21:27:35 UTC) #3

Kenneth Waters

lgtm. Just want to make sure you mean to delete help.h

10 years, 2 months ago (2010-10-20 21:31:11 UTC) #4

Luigi Semenzato

10 years, 2 months ago (2010-10-20 21:43:08 UTC) #5

Thanks for inquiring.  From the Makefile:

clean:
	rm -f $(TPM_NVTOOL) *.o *.d help/help.h

Will push.


On Wed, Oct 20, 2010 at 2:31 PM,  <kwaters@chromium.org> wrote:
> lgtm.
>
> Just want to make sure you mean to delete help.h
>
> http://codereview.chromium.org/3989001/show
>

Expand Messages | Collapse Messages