Issue 3987001: common.sh, ...: add support for ext2-ro/rw hack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3987001: common.sh, ...: add support for ext2-ro/rw hack (Closed)

Created:
10 years, 2 months ago by Will Drewry

Modified:
9 years, 7 months ago

Reviewers:
gauravsh

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
http://git.chromium.org/git/vboot_reference.git

Visibility:
Public.

Description

common.sh, ...: add support for ext2-ro/rw hack Copies the helpers from crosutils.git/common.sh but uses printf with octals for portability. This should update all locations where we mount root rw and disable_rw_mounts just before a final sign. TEST= tested with a sign and verify using official keys. Then manually checked with dumpe2fs if it worked and kept the ro protection. BUG=chromium-os:7972 Change-Id: Ibdd23cb30335942c36d537663aabea605a2f8704

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -0 lines)			Patch
M	scripts/image_signing/common.sh	View	1 2	2 chunks	+77 lines, -0 lines	0 comments	Download
M	scripts/image_signing/make_dev_ssd.sh	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	scripts/image_signing/sign_official_build.sh	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Will Drewry

As per our conversation, I folded this into the existing helpers by adding a check ...

10 years, 2 months ago (2010-10-21 21:35:47 UTC) #2

LGTM, thanks!

Expand Messages | Collapse Messages

Issue 3987001: common.sh, ...: add support for ext2-ro/rw hack (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix offset #

Patch Set 3 : fold the rw work in; add ext2 sb magic check #

Messages