Issue 3986004: Remove DestructionObserver for NetworkConfigWatcherMac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3986004: Remove DestructionObserver for NetworkConfigWatcherMac. (Closed)

Created:
10 years, 2 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove DestructionObserver for NetworkConfigWatcherMac. Subclass base::Thread so we can control initialization and shutdown for the helper thread. BUG=59630 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63650

Patch Set 1 #

Patch Set 2 : Fix build errors. #

Patch Set 3 : Another build error :) #

Patch Set 4 : Fix template param. #

Patch Set 5 : Only clean up if we need to. #

Total comments: 1

Patch Set 6 : Remove unnecessary bits. #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -48 lines)			Patch
	M	net/base/network_config_watcher_mac.h	View		2 chunks	+1 line, -14 lines	0 comments	Download
	M	net/base/network_config_watcher_mac.cc	View	1 2 3 4 5	3 chunks	+54 lines, -34 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eroman

LGTM http://codereview.chromium.org/3986004/diff/9001/10001 File net/base/network_config_watcher_mac.cc (right): http://codereview.chromium.org/3986004/diff/9001/10001#newcode113 net/base/network_config_watcher_mac.cc:113: // check that the notifier thread shut down ...

10 years, 2 months ago (2010-10-23 04:02:35 UTC) #2

willchan no longer on Chromium

10 years, 2 months ago (2010-10-23 04:05:43 UTC) #3

On Fri, Oct 22, 2010 at 9:02 PM, <eroman@chromium.org> wrote:

> LGTM
>
>
> http://codereview.chromium.org/3986004/diff/9001/10001
> File net/base/network_config_watcher_mac.cc (right):
>
> http://codereview.chromium.org/3986004/diff/9001/10001#newcode113
> net/base/network_config_watcher_mac.cc:113: // check that the notifier
> thread shut down properly.
> I am not sure I understand this comment. What do we sanity check?

Oops, I should delete that comment.  I think you wrote it before since I
don't recognize it.  It was probably to let us check that the member
variable was indeed deleted and NULL'd out after the thread stopped.
 Doesn't make sense any more.

>
>
> http://codereview.chromium.org/3986004/show
>

Expand Messages | Collapse Messages