Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: chrome/browser/printing/print_dialog_cloud_uitest.cc

Issue 3983005: Revert 63600 - Thread IO safety: annotate file_util, and block IO thread from... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/url_request_mock_util.cc ('k') | chrome/browser/service/service_process_control.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_dialog_cloud_uitest.cc
===================================================================
--- chrome/browser/printing/print_dialog_cloud_uitest.cc (revision 63629)
+++ chrome/browser/printing/print_dialog_cloud_uitest.cc (working copy)
@@ -11,7 +11,6 @@
#include "base/file_util.h"
#include "base/path_service.h"
#include "base/singleton.h"
-#include "base/thread_restrictions.h"
#include "base/values.h"
#include "chrome/browser/browser_list.h"
#include "chrome/browser/browser_thread.h"
@@ -33,11 +32,7 @@
public:
TestData() {}
- const char* GetTestData() {
- // Fetching this data blocks the IO thread, but we don't really care because
- // this is a test.
- base::ThreadRestrictions::ScopedAllowIO allow_io;
-
+ char* GetTestData() {
if (test_data_.empty()) {
FilePath test_data_directory;
PathService::Get(chrome::DIR_TEST_DATA, &test_data_directory);
@@ -45,7 +40,7 @@
test_data_directory.AppendASCII("printing/cloud_print_uitest.html");
file_util::ReadFileToString(test_file, &test_data_);
}
- return test_data_.c_str();
+ return &test_data_[0];
}
private:
std::string test_data_;
« no previous file with comments | « chrome/browser/net/url_request_mock_util.cc ('k') | chrome/browser/service/service_process_control.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698