Revert 63600 - Thread IO safety: annotate file_util, and block IO thread from...

Revert 63600 - Thread IO safety: annotate file_util, and block IO thread from doing IO

Reverting because this breaks the ChromiumOS (dbg) builder.

- Mark functions in file_util_posix as requiring permission to perform
  disk actions.
- Mark the IO thread as disallowed from performing disk actions.
- Temporarily work around the protections in places where we currently
  have bugs.

BUG=59847, 59849, 60207, 60211
TEST=no dchecks in debug builds

Review URL: http://codereview.chromium.org/3872002

TBR=evan@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63630

[Evan Martin, 2010-10-23 05:10:10]

What is the breakage?  Can you include the error?

On Fri, Oct 22, 2010 at 9:09 PM,  <isherman@chromium.org> wrote:
> Reviewers: Evan Martin,
>
> Description:
> Revert 63600 - Thread IO safety: annotate file_util, and block IO thread
> from
> doing IO
>
> Reverting because this breaks the ChromiumOS (dbg) builder.
>
> - Mark functions in file_util_posix as requiring permission to perform
>  disk actions.
> - Mark the IO thread as disallowed from performing disk actions.
> - Temporarily work around the protections in places where we currently
>  have bugs.
>
> BUG=59847,59849,60207,60211
> TEST=no dchecks in debug builds
>
> Review URL: http://codereview.chromium.org/3872002
>
> TBR=evan@chromium.org
>
> Please review this at http://codereview.chromium.org/3983005/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     base/file_util_posix.cc
>  M     base/shared_memory_posix.cc
>  M     base/thread_restrictions.h
>  M     base/thread_restrictions.cc
>  M     chrome/browser/extensions/autoupdate_interceptor.cc
>  M     chrome/browser/io_thread.cc
>  M     chrome/browser/net/url_request_mock_http_job.cc
>  M     chrome/browser/net/url_request_mock_util.cc
>  M     chrome/browser/printing/print_dialog_cloud_uitest.cc
>  M     chrome/browser/service/service_process_control.cc
>  M     chrome/common/extensions/extension_resource.cc
>  M     net/socket/ssl_client_socket_nss.cc
>  M     net/url_request/url_request_file_job.cc
>
>
>

[Evan Martin, 2010-10-23 05:21:05]

Nevermind, got it.

On Fri, Oct 22, 2010 at 10:10 PM, Evan Martin <evan@chromium.org> wrote:
> What is the breakage?  Can you include the error?
>
> On Fri, Oct 22, 2010 at 9:09 PM,  <isherman@chromium.org> wrote:
>> Reviewers: Evan Martin,
>>
>> Description:
>> Revert 63600 - Thread IO safety: annotate file_util, and block IO thread
>> from
>> doing IO
>>
>> Reverting because this breaks the ChromiumOS (dbg) builder.
>>
>> - Mark functions in file_util_posix as requiring permission to perform
>>  disk actions.
>> - Mark the IO thread as disallowed from performing disk actions.
>> - Temporarily work around the protections in places where we currently
>>  have bugs.
>>
>> BUG=59847,59849,60207,60211
>> TEST=no dchecks in debug builds
>>
>> Review URL: http://codereview.chromium.org/3872002
>>
>> TBR=evan@chromium.org
>>
>> Please review this at http://codereview.chromium.org/3983005/show
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>>
>> Affected files:
>>  M     base/file_util_posix.cc
>>  M     base/shared_memory_posix.cc
>>  M     base/thread_restrictions.h
>>  M     base/thread_restrictions.cc
>>  M     chrome/browser/extensions/autoupdate_interceptor.cc
>>  M     chrome/browser/io_thread.cc
>>  M     chrome/browser/net/url_request_mock_http_job.cc
>>  M     chrome/browser/net/url_request_mock_util.cc
>>  M     chrome/browser/printing/print_dialog_cloud_uitest.cc
>>  M     chrome/browser/service/service_process_control.cc
>>  M     chrome/common/extensions/extension_resource.cc
>>  M     net/socket/ssl_client_socket_nss.cc
>>  M     net/url_request/url_request_file_job.cc
>>
>>
>>
>