Issue 398004: Try https proxy for websocket connection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 398004: Try https proxy for websocket connection. (Closed)

Created:
11 years, 1 month ago by ukai

Modified:
9 years, 7 months ago

Reviewers:
tyoshino (SeeGerritForStatus), Yuzo

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Try https proxy for websocket connection. Safari always uses "https" to get proxies for websocket connection, so chrome also tries it as well. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32045

Patch Set 1 #

Patch Set 2 : try https proxy #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	net/socket_stream/socket_stream.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	net/socket_stream/socket_stream.cc	View	1	3 chunks	+16 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ukai

Make SocketStream try with https proxy as well. For now, I believe most environments configure ...

11 years, 1 month ago (2009-11-16 07:07:02 UTC) #1

tyoshino (SeeGerritForStatus)

LGTM http://codereview.chromium.org/398004/diff/2001/3001 File net/socket_stream/socket_stream.cc (right): http://codereview.chromium.org/398004/diff/2001/3001#newcode432 Line 432: // If proxy was not found for ...

11 years, 1 month ago (2009-11-16 07:33:49 UTC) #2

LGTM

Expand Messages | Collapse Messages