Issue 398002: Skip debugger frames when looking for calling context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 398002: Skip debugger frames when looking for calling context (Closed)

Created:
11 years, 1 month ago by yurys

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, Vitaly Repeshko, Mads Ager (chromium), abarth-chromium

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Skip debugger frames when looking for calling context. BUG=509 Committed: http://code.google.com/p/v8/source/detail?r=3310

Patch Set 4 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -0 lines)			Patch
	M	src/top.cc	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download
	M	test/cctest/test-debug.cc	View	1 2 3	1 chunk	+83 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/398002/diff/4002/4003 File test/cctest/test-debug.cc (right): http://codereview.chromium.org/398002/diff/4002/4003#newcode5674 Line 5674: // Create a function for testing beak. ...

11 years, 1 month ago (2009-11-16 07:34:08 UTC) #3

yurys

11 years, 1 month ago (2009-11-16 14:20:51 UTC) #4

http://codereview.chromium.org/398002/diff/4002/4003
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/398002/diff/4002/4003#newcode5674
Line 5674: // Create a function for testing beak.
On 2009/11/16 07:34:08, Søren Gjesse wrote:
> beak?

Done.

Expand Messages | Collapse Messages

Issue 398002: Skip debugger frames when looking for calling context (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages