Issue 3973004: scripts: Remove bogus patch to software-update.conf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3973004: scripts: Remove bogus patch to software-update.conf (Closed)

Created:
10 years, 2 months ago by Elly Fong-Jones

Modified:
9 years, 4 months ago

Reviewers:
drewry, kliegs

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa, petkov

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Description

scripts: Remove bogus patch to software-update.conf This caused a build break after http://codereview.chromium.org/3995007 was committed, since we try to patch a now-nonexistent file. BUG=None TEST=Adhoc ./mod_image_for_test.sh --factory_install doesn't hang Change-Id: Iac299c850765eedfcefcffb80c385b0e8c0fa277 Signed-off-by: Elly Jones <ellyjones@chromium.org>; Signed-off-by: Kliegs <kliegs@chromium.org>; Signed-off-by: Will Drewry <wad@chromium.org>; Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=01693fe

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -15 lines)			Patch
	M	mod_for_factory_scripts/200patchInitScript	View		1 chunk	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Will Drewry

10 years, 2 months ago (2010-10-22 13:46:22 UTC) #3

LGTM

I suspect this will need to be mirrored in chromeos-factoryinstall, but the tree
should go green without that I *think*.  (If not, then I say we revert it all :)

Expand Messages | Collapse Messages