Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 3973001: Change PCR extend call to capture the state of both recovery and dev modes (Closed)

Created:
10 years, 2 months ago by gauravsh
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, Randall Spangler, Bill Richardson
Visibility:
Public.

Description

Change PCR extend call to capture the state of both recovery and dev modes Change-Id: I3f18081bda888a0fa6f56a67d0cef17268014706 BUG=chromium-os:6714 TEST=manual by enabling ROLLBACK_TPM in firmware/Makefile (did not test by compiling under MSVC) Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=82602d7

Patch Set 1 #

Patch Set 2 : whitespace #

Total comments: 2

Patch Set 3 : return right error code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -11 lines) Patch
M firmware/lib/rollback_index.c View 1 2 3 chunks +28 lines, -10 lines 0 comments Download
M firmware/version.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
gauravsh
10 years, 2 months ago (2010-10-20 20:21:44 UTC) #1
Luigi Semenzato
LGTM after examining one small suggestion which you may ignore but I am sure you ...
10 years, 2 months ago (2010-10-20 20:30:58 UTC) #2
Luigi Semenzato
Sorry, I inverted rv and rve in the last part of the last sentence. You ...
10 years, 2 months ago (2010-10-20 20:33:52 UTC) #3
gauravsh
http://codereview.chromium.org/3973001/diff/2001/3001 File firmware/lib/rollback_index.c (right): http://codereview.chromium.org/3973001/diff/2001/3001#newcode407 firmware/lib/rollback_index.c:407: return rv; On 2010/10/20 20:30:58, Luigi Semenzato wrote: > ...
10 years, 2 months ago (2010-10-20 20:49:39 UTC) #4
Luigi Semenzato
LGTM still. On 2010/10/20 20:49:39, gauravsh wrote: > http://codereview.chromium.org/3973001/diff/2001/3001 > File firmware/lib/rollback_index.c (right): > > ...
10 years, 2 months ago (2010-10-20 23:50:48 UTC) #5
gauravsh
Randall: What's your opinion on this change? High risk/low risk to go into the firmware ...
10 years, 2 months ago (2010-10-21 00:37:41 UTC) #6
Randall Spangler
10 years, 2 months ago (2010-10-21 21:17:19 UTC) #7
LGTM.

Let's get this in immediately, if not sooner.  I'm going to do a test build in
the next 1/2 day and can include this change.

Powered by Google App Engine
This is Rietveld 408576698