Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 397032: linux: set a compiler flag that drops the eh_frame section (Closed)

Created:
11 years, 1 month ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

linux: set a compiler flag that drops the eh_frame section eh_frame is data used for exception frames. We already disable exceptions, but it turns out this obscure extra flag was responsible for the eh_frame making it into our binaries. This shaves off another few megabytes from our binaries. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32254

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Evan Martin
11 years, 1 month ago (2009-11-18 00:58:13 UTC) #1
Evan Martin
11 years, 1 month ago (2009-11-18 00:58:23 UTC) #2
agl
LGTM
11 years, 1 month ago (2009-11-18 01:01:26 UTC) #3
Joel Stanley (old)
LGTM. Tested with gcc-4.4 and gold. Saved us 6.5MB on my x64 Release build (47665692 ...
11 years, 1 month ago (2009-11-18 01:35:08 UTC) #4
Hironori Bono
Evan, Sorry for my stupid comment in advance. If I recall correctly, gcc (x64) sometimes ...
11 years, 1 month ago (2009-11-18 09:13:29 UTC) #5
Craig
On 2009/11/18 09:13:29, hbono wrote: > Evan, > > Sorry for my stupid comment in ...
11 years, 1 month ago (2009-11-18 12:22:56 UTC) #6
Evan Martin
On 2009/11/18 09:13:29, hbono wrote: > Sorry for my stupid comment in advance. I have ...
11 years, 1 month ago (2009-11-18 19:09:29 UTC) #7
Evan Martin
11 years, 1 month ago (2009-11-18 19:09:53 UTC) #8
On 2009/11/18 12:22:56, Craig wrote:
> No stacktrace is not good :(

We already don't have symbols in release, so I'm not too sad about breaking
this.

Powered by Google App Engine
This is Rietveld 408576698