Launch processes asynchronously so as not to block the UI thread. For now, re...

base/process_util_posix.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <dirent.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <signal.h>
 #include <stdlib.h>
 #include <sys/resource.h>
@@ skipping 108 matching lines @@
 }
 
 ProcessId GetProcId(ProcessHandle process) {
   return process;
 }
 
 // Attempts to kill the process identified by the given process
 // entry structure.  Ignores specified exit_code; posix can't force that.
 // Returns true if this is successful, false otherwise.
 bool KillProcess(ProcessHandle process_id, int exit_code, bool wait) {
-  DCHECK(process_id > 1);
-  if (process_id <= 1) {
-    LOG(ERROR) << "tried to kill process_id " << process_id;
+  DCHECK_GT(process_id, 1) << " tried to kill invalid process_id";
+  if (process_id <= 1)
     return false;
-  }
 
   bool result = kill(process_id, SIGTERM) == 0;
 
   if (result && wait) {
     int tries = 60;
     // The process may not end immediately due to pending I/O
     bool exited = false;
     while (tries-- > 0) {
       pid_t pid = HANDLE_EINTR(waitpid(process_id, NULL, WNOHANG));
       if (pid == process_id) {
@@ skipping 562 matching lines @@
                       const ProcessFilter* filter) {
   bool exited_cleanly =
       WaitForProcessesToExit(executable_name, wait_milliseconds,
                              filter);
   if (!exited_cleanly)
     KillProcesses(executable_name, exit_code, filter);
   return exited_cleanly;
 }
 
 }  // namespace base