Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 397029: Move git-cl to src.chromium.org (Closed)

Created:
11 years, 1 month ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M git-cl View 1 chunk +7 lines, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
Mandeep Singh Baines
11 years, 1 month ago (2009-11-17 23:02:23 UTC) #1
Evan Martin
LGTM
11 years, 1 month ago (2009-11-17 23:06:01 UTC) #2
M-A Ruel
11 years, 1 month ago (2009-11-18 00:13:58 UTC) #3
lgtm

http://codereview.chromium.org/397029/diff/1/2
File git-cl (right):

http://codereview.chromium.org/397029/diff/1/2#newcode7
Line 7: url="http://src.chromium.org/git/git-cl.git"
This is cool but somewhat aggressive, especially when testing. Not a big deal. I
guess the best workaround is simply to have git-cl in the path prior
depot_tools.

Powered by Google App Engine
This is Rietveld 408576698