Issue 397017: reland 31875. Revert was:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 397017: reland 31875. Revert was:... (Closed)

Created:
11 years, 1 month ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
huanr

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, jam, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

reland 31875. Revert was: ------ Revert 31875 to see whether it fixes reliability bot. BUG=25677 TEST=None ------ TBR=huanr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32112

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+230 lines, -135 lines)			Patch
M	base/file_util.h	View		3 chunks	+8 lines, -12 lines	0 comments	Download
M	base/file_util.cc	View		2 chunks	+27 lines, -0 lines	0 comments	Download
M	base/file_util_posix.cc	View		2 chunks	+9 lines, -33 lines	0 comments	Download
M	base/file_util_win.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	build/common.gypi	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/profile.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View		2 chunks	+13 lines, -2 lines	0 comments	Download
M	chrome/browser/spellcheck_host.h	View		6 chunks	+15 lines, -7 lines	0 comments	Download
M	chrome/browser/spellcheck_host.cc	View		5 chunks	+60 lines, -24 lines	0 comments	Download
M	chrome/chrome.gyp	View		5 chunks	+15 lines, -8 lines	0 comments	Download
M	chrome/common/notification_type.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/common/render_messages.h	View		5 chunks	+5 lines, -14 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/renderer/render_thread.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/renderer/render_thread.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View		2 chunks	+14 lines, -6 lines	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck.h	View		4 chunks	+3 lines, -7 lines	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck.cc	View		5 chunks	+8 lines, -6 lines	0 comments	Download
M	ipc/ipc.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	ipc/ipc_platform_file.h	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages