Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: src/runtime.h

Issue 3970005: Make Failure inherit from MaybeObject instead of Object. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/property.h ('k') | src/runtime.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime.h
===================================================================
--- src/runtime.h (revision 5696)
+++ src/runtime.h (working copy)
@@ -486,7 +486,8 @@
// Returns failure if an allocation fails. In this case, it must be
// retried with a new, empty StringDictionary, not with the same one.
// Alternatively, heap initialization can be completely restarted.
- static Object* InitializeIntrinsicFunctionNames(Object* dictionary);
+ MUST_USE_RESULT static MaybeObject* InitializeIntrinsicFunctionNames(
+ Object* dictionary);
// Get the intrinsic function with the given name, which must be a symbol.
static Function* FunctionForSymbol(Handle<String> name);
@@ -504,23 +505,29 @@
// Support getting the characters in a string using [] notation as
// in Firefox/SpiderMonkey, Safari and Opera.
- static Object* GetElementOrCharAt(Handle<Object> object, uint32_t index);
- static Object* GetElement(Handle<Object> object, uint32_t index);
+ MUST_USE_RESULT static MaybeObject* GetElementOrCharAt(Handle<Object> object,
+ uint32_t index);
+ MUST_USE_RESULT static MaybeObject* GetElement(Handle<Object> object,
+ uint32_t index);
- static Object* SetObjectProperty(Handle<Object> object,
- Handle<Object> key,
- Handle<Object> value,
- PropertyAttributes attr);
+ MUST_USE_RESULT static MaybeObject* SetObjectProperty(
+ Handle<Object> object,
+ Handle<Object> key,
+ Handle<Object> value,
+ PropertyAttributes attr);
- static Object* ForceSetObjectProperty(Handle<JSObject> object,
- Handle<Object> key,
- Handle<Object> value,
- PropertyAttributes attr);
+ MUST_USE_RESULT static MaybeObject* ForceSetObjectProperty(
+ Handle<JSObject> object,
+ Handle<Object> key,
+ Handle<Object> value,
+ PropertyAttributes attr);
- static Object* ForceDeleteObjectProperty(Handle<JSObject> object,
- Handle<Object> key);
+ MUST_USE_RESULT static MaybeObject* ForceDeleteObjectProperty(
+ Handle<JSObject> object,
+ Handle<Object> key);
- static Object* GetObjectProperty(Handle<Object> object, Handle<Object> key);
+ MUST_USE_RESULT static MaybeObject* GetObjectProperty(Handle<Object> object,
+ Handle<Object> key);
// This function is used in FunctionNameUsing* tests.
static Object* FindSharedFunctionInfoInScript(Handle<Script> script,
« no previous file with comments | « src/property.h ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698