Issue 3968006: Consider zero a valid kernel version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3968006: Consider zero a valid kernel version. (Closed)

Created:
10 years, 2 months ago by vb

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
http://git.chromium.org/git/vboot_reference.git

Visibility:
Public.

Description

Consider zero a valid kernel version. SAFT testing requires changing kernel version to one level below the current value (set to 1). This change allows version number set to zero for test purposes. Change-Id: Ia6f11578d9a6bc8c5544c56413c5589011d6334a BUG=chromium-os:1976 TEST=manual Ran `vbutil_kernel --repack --version 0 <other params>' it used to fail, now it succeeds. This is also verified by using in http://codereview.chromium.org/3781016 to support TPM testing. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=00b9088

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	utility/vbutil_kernel.c	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

LGTM Please check that firmware also handles version=0 before committing this.

10 years, 2 months ago (2010-10-21 20:37:16 UTC) #2

10 years, 2 months ago (2010-10-21 20:46:28 UTC) #3

On Thu, Oct 21, 2010 at 1:37 PM,  <rspangler@chromium.org> wrote:
> LGTM
>
> Please check that firmware also handles version=0 before committing this.
>
>
> http://codereview.chromium.org/3968006/show
>

verified that if TPM kernel version value is set to zero, kernel with
version of zero boots successfully.

Expand Messages | Collapse Messages