Update code that previously constructed strings from string iterators only to...

net/base/x509_certificate_openssl.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/x509_certificate.h"
 
 #include <openssl/asn1.h>
 #include <openssl/crypto.h>
 #include <openssl/obj_mac.h>
 #include <openssl/pem.h>
@@ skipping 110 matching lines @@
                        x509_time->length);
   // UTCTime: YYMMDDHHMMSSZ
   // GeneralizedTime: YYYYMMDDHHMMSSZ
   size_t year_length = x509_time->type == V_ASN1_UTCTIME ? 2 : 4;
   size_t fields_offset = x509_time->type == V_ASN1_UTCTIME ? 0 : 2;
 
   if (str_date.length() < 11 + year_length)
     return;
 
   base::Time::Exploded exploded = {0};
-  bool valid = base::StringToInt(str_date.substr(0, year_length),
+  bool valid = base::StringToInt(str_date.begin(),
+                                 str_date.begin() + year_length,
                                  &exploded.year);
   if (valid && year_length == 2)
     exploded.year += exploded.year < 50 ? 2000 : 1900;
 
-  valid &= base::StringToInt(str_date.substr(2 + fields_offset, 2),
+  valid &= base::StringToInt(str_date.begin() + fields_offset + 2,
+                             str_date.begin() + fields_offset + 4,
                              &exploded.month);
-  valid &= base::StringToInt(str_date.substr(4 + fields_offset, 2),
+  valid &= base::StringToInt(str_date.begin() + fields_offset + 4,
+                             str_date.begin() + fields_offset + 6),
                              &exploded.day_of_month);
-  valid &= base::StringToInt(str_date.substr(6 + fields_offset, 2),
+  valid &= base::StringToInt(str_date.begin() + fields_offset + 6,
+                             str_date.begin() + fields_offset + 8),
                              &exploded.hour);
-  valid &= base::StringToInt(str_date.substr(8 + fields_offset, 2),
+  valid &= base::StringToInt(str_date.begin() + fields_offset + 8,
+                             str_date.begin() + fields_offset + 10),
                              &exploded.minute);
-  valid &= base::StringToInt(str_date.substr(10 + fields_offset, 2),
+  valid &= base::StringToInt(str_date.begin() + fields_offset + 10,
+                             str_date.begin() + fields_offset + 12,
                              &exploded.second);
 
   DCHECK(valid);
 
   *time = base::Time::FromUTCExploded(exploded);
 }
 
 void ParseSubjectAltNames(X509Certificate::OSCertHandle cert,
                           std::vector<std::string>* dns_names) {
   int index = X509_get_ext_by_NID(cert, NID_subject_alt_name, -1);
@@ skipping 325 matching lines @@
   // cache the DER (if not already cached via X509_set_ex_data).
   DERCache der_cache_a, der_cache_b;
 
   return GetDERAndCacheIfNeeded(a, &der_cache_a) &&
       GetDERAndCacheIfNeeded(b, &der_cache_b) &&
       der_cache_a.data_length == der_cache_b.data_length &&
       memcmp(der_cache_a.data, der_cache_b.data, der_cache_a.data_length) == 0;
 }
 
 } // namespace net