Update code that previously constructed strings from string iterators only to...

chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Implementation of the SafeBrowsingBlockingPage class.
 
 #include "chrome/browser/safe_browsing/safe_browsing_blocking_page.h"
 
 #include <string>
 
@@ skipping 313 matching lines @@
     // We are deleted after this.
     return;
   }
 
   // The "report error" and "show diagnostic" commands can have a number
   // appended to them, which is the index of the element they apply to.
   int element_index = 0;
   size_t colon_index = command.find(':');
   if (colon_index != std::string::npos) {
     DCHECK(colon_index < command.size() - 1);
-    std::string index_str = command.substr(colon_index + 1);
     command = command.substr(0, colon_index);
-    bool result = base::StringToInt(index_str, &element_index);
+    bool result = base::StringToInt(command.begin() + colon_index + 1,
+                                    command.end(),
+                                    &element_index);
     DCHECK(result);
   }
 
   if (element_index >= static_cast<int>(unsafe_resources_.size())) {
     NOTREACHED();
     return;
   }
 
   std::string bad_url_spec = unsafe_resources_[element_index].url.spec();
   if (command == kReportErrorCommand) {
@@ skipping 184 matching lines @@
   UnsafeResourceMap* unsafe_resource_map = GetUnsafeResourcesMap();
   (*unsafe_resource_map)[tab_contents].push_back(unsafe_resource);
 }
 
 // static
 bool SafeBrowsingBlockingPage::IsMainPage(
     const UnsafeResourceList& unsafe_resources) {
   return unsafe_resources.size() == 1 &&
          unsafe_resources[0].resource_type == ResourceType::MAIN_FRAME;
 }