Fix args to RunCommand

bin/cbuildbot.py

 #!/usr/bin/python
 
 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """CBuildbot is wrapper around the build process used by the pre-flight queue"""
 
 import errno
 import re
@@ skipping 65 matching lines @@
 
 def _GetAllGitRepos(buildroot, debug=False):
   """Returns a list of tuples containing [git_repo, src_path]."""
   manifest_tuples = []
   # Gets all the git repos from a full repo manifest.
   repo_cmd = "repo manifest -o -".split()
   output = RunCommand(repo_cmd, cwd=buildroot, redirect_stdout=True,
                       redirect_stderr=True, print_cmd=debug)
 
   # Extract all lines containg a project.
-  extract_cmd = ["grep", "project name="]
+  extract_cmd = ['grep', 'project name=']
   output = RunCommand(extract_cmd, cwd=buildroot, input=output,
                       redirect_stdout=True, print_cmd=debug)
   # Parse line using re to get tuple.
   result_array = re.findall('.+name=\"([\w-]+)\".+path=\"(\S+)".+', output)
 
   # Create the array.
   for result in result_array:
     if len(result) != 2:
       Warning('Found incorrect xml object %s' % result)
     else:
@@ skipping 185 matching lines @@
   cwd = os.path.join(buildroot, 'src', 'scripts')
   RunCommand(['./build_image', '--replace'], cwd=cwd, enter_chroot=True)
 
 
 def _BuildVMImageForTesting(buildroot):
   (vdisk_size, statefulfs_size) = _GetVMConstants(buildroot)
   cwd = os.path.join(buildroot, 'src', 'scripts')
   RunCommand(['./image_to_vm.sh',
               '--test_image',
               '--full',
-              '--vdisk_size %s' % vdisk_size,
-              '--statefulfs_size %s' % statefulfs_size,
+              '--vdisk_size=%s' % vdisk_size,
+              '--statefulfs_size=%s' % statefulfs_size,
               ], cwd=cwd, enter_chroot=True)
 
 
 def _RunUnitTests(buildroot):
   cwd = os.path.join(buildroot, 'src', 'scripts')
   RunCommand(['./cros_run_unit_tests'], cwd=cwd, enter_chroot=True)
 
 
 def _RunSmokeSuite(buildroot):
   cwd = os.path.join(buildroot, 'src', 'scripts')
   RunCommand(['bin/cros_run_vm_test',
               '--no_graphics',
-              '--test_case',
-              'suite_Smoke',
+              '--test_case=suite_Smoke',
               ], cwd=cwd, error_ok=False)
 
 
 def _UprevPackages(buildroot, revisionfile, board):
   """Uprevs a package based on given revisionfile.
 
   If revisionfile is set to None or does not resolve to an actual file, this
   function will uprev all packages.
 
   Keyword arguments:
@@ skipping 31 matching lines @@
   RunCommand(['./cros_mark_as_stable', '--srcroot=..',
               '--tracking_branch="cros/master"', 'clean'],
              cwd=cwd, error_ok=error_ok)
 
 
 def _UprevPush(buildroot):
   """Pushes uprev changes to the main line."""
   cwd = os.path.join(buildroot, 'src', 'scripts')
   RunCommand(['./cros_mark_as_stable', '--srcroot=..',
               '--tracking_branch="cros/master"',
-              '--push_options', '--bypass-hooks -f', 'push'],
+              '--push_options="--bypass-hooks -f"', 'push'],
              cwd=cwd)
 
 
 def _GetConfig(config_name):
   """Gets the configuration for the build"""
   default = config['default']
   buildconfig = {}
   if not config.has_key(config_name):
     Warning('Non-existent configuration specified.')
     Warning('Please specify one of:')
@@ skipping 94 matching lines @@
   except:
     # Send failure to master bot.
     if not buildconfig['master'] and buildconfig['important']:
       cbuildbot_comm.PublishStatus(cbuildbot_comm.STATUS_BUILD_FAILED)
 
     raise
 
 
 if __name__ == '__main__':
     main()