AU: Restrict URL/version change over D-Bus to non-official builds only.

dbus_service.cc

 // Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "update_engine/dbus_service.h"
+
 #include <string>
-#include "base/logging.h"
+
+#include <base/logging.h>
+
 #include "update_engine/marshal.glibmarshal.h"
+#include "update_engine/utils.h"
 
 using std::string;
 
 G_DEFINE_TYPE(UpdateEngineService, update_engine_service, G_TYPE_OBJECT)
 
 static void update_engine_service_finalize(GObject* object) {
   G_OBJECT_CLASS(update_engine_service_parent_class)->finalize(object);
 }
 
 static guint status_update_signal = 0;
@@ skipping 25 matching lines @@
 
 UpdateEngineService* update_engine_service_new(void) {
   return reinterpret_cast<UpdateEngineService*>(
       g_object_new(UPDATE_ENGINE_TYPE_SERVICE, NULL));
 }
 
 gboolean update_engine_service_attempt_update(UpdateEngineService* self,
                                               gchar* app_version,
                                               gchar* omaha_url,
                                               GError **error) {
-  const string update_app_version = app_version ? app_version : "";
-  const string update_omaha_url = omaha_url ? omaha_url : "";
+  string update_app_version;
+  string update_omaha_url;
+  // Only non-official (e.g., dev and test) builds can override the current
+  // version and update server URL over D-Bus.
+  if (!chromeos_update_engine::utils::IsOfficialBuild()) {
+    if (app_version) {
+      update_app_version = app_version;
+    }
+    if (omaha_url) {
+      update_omaha_url = omaha_url;
+    }
+  }
   LOG(INFO) << "Attempt update: app_version=\"" << update_app_version << "\" "
             << "omaha_url=\"" << update_omaha_url << "\"";
   self->update_attempter_->CheckForUpdate(app_version, omaha_url);
   return TRUE;
 }
 
 gboolean update_engine_service_get_status(UpdateEngineService* self,
                                           int64_t* last_checked_time,
                                           double* progress,
                                           gchar** current_operation,
@@ skipping 37 matching lines @@
   g_signal_emit(self,
                 status_update_signal,
                 0,
                 last_checked_time,
                 progress,
                 current_operation,
                 new_version,
                 new_size);
   return TRUE;
 }