Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 3962005: AU: Don't request data ranges beyond the end of the payload. (Closed)

Created:
10 years, 2 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
adlr
CC:
chromium-os-reviews_chromium.org, petkov, adlr
Visibility:
Public.

Description

AU: Don't request data ranges beyond the end of the payload. This avoids 416 HTTP response error codes from the server. Note that even without this change update would eventually succeed due to more than 10 resume failures (so the safety net actually worked). BUG=8017 TEST=unit tests; tested on device by first reproducing the issue by interrupting an update during the finalizing step and then getting 416, then verified the patch resumes the update. Also, verified updates interrupted in the middle of the download resume correctly. Change-Id: Iede50a8f8a9d6c000cfeb03308e9ea4f3db74e1b Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b21ce5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M update_attempter.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
petkov
10 years, 2 months ago (2010-10-21 22:53:15 UTC) #1
adlr
10 years, 2 months ago (2010-10-21 22:58:08 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698