Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 396006: Revert 32012-32017 (Closed)

Created:
11 years, 1 month ago by Mohamed Mansour
Modified:
9 years, 6 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Revert 32012-32017 git cl dcommit somehow committed all my local changes in cygwin TBR=evan BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -402 lines) Patch
D chrome/browser/views/accessible_toolbar_view.h View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/views/accessible_toolbar_view.cc View 1 chunk +0 lines, -273 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.h View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 3 chunks +23 lines, -7 lines 0 comments Download
M chrome/browser/views/detachable_toolbar_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/views/frame/browser_view.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 6 chunks +5 lines, -15 lines 0 comments Download
M chrome/browser/views/toolbar_view.h View 6 chunks +33 lines, -6 lines 0 comments Download
M chrome/browser/views/toolbar_view.cc View 4 chunks +245 lines, -4 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
M views/controls/button/menu_button.h View 3 chunks +0 lines, -8 lines 0 comments Download
M views/controls/button/menu_button.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mohamed Mansour
I was working on one patch "branchFoo" then I did "git checkout -b branchBar" I ...
11 years, 1 month ago (2009-11-15 03:25:40 UTC) #1
Evan Martin
11 years, 1 month ago (2009-11-15 05:16:50 UTC) #2
"git cl dcommit" doesn't work with any arguments, so it committed everything it
found.  It is a bad UI.  I will fix it, really sorry!

Powered by Google App Engine
This is Rietveld 408576698