Issue 3959001: Revert r5455 from the 2.4 branch....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3959001: Revert r5455 from the 2.4 branch.... (Closed)

Created:
10 years, 2 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google), Mads Ager (chromium)

CC:
v8-dev, kerz_chromium, laforge

Base URL:
http://v8.googlecode.com/svn/branches/2.4/

Visibility:
Public.

Description

Revert r5455 from the 2.4 branch. That's an experimental revert to see if r5455 provoked crbug.com/59202. It's more involved than plain unpatch due to merge conflicts. Committed: http://code.google.com/p/v8/source/detail?r=5679

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -85 lines)			Patch
M	src/global-handles.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/global-handles.cc	View	3 chunks	+1 line, -4 lines	0 comments	Download
M	src/heap.h	View	2 chunks	+3 lines, -16 lines	0 comments	Download
M	src/heap.cc	View	8 chunks	+32 lines, -51 lines	0 comments	Download
M	src/heap-inl.h	View	2 chunks	+1 line, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

antonm

Mads and Slava, TBRing to you, sorry, want it to be picked up by next ...

10 years, 2 months ago (2010-10-20 19:28:18 UTC) #1

Mads Ager (chromium)

10 years, 2 months ago (2010-10-21 05:48:47 UTC) #2

LGTM

Anton, I think this is fine. However, please revert on bleeding_edge as well.
Then if you see that this is not causing the problem, reintroduce the change on
bleeding_edge and merge to 2.4 again.

I would probably have reverted on bleeding_edge and merged that to the 2.4
branch.

Expand Messages | Collapse Messages