Issue 3956005: Use minimums if options are too small.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3956005: Use minimums if options are too small. (Closed)

Created:
10 years, 2 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Use minimums if options are too small. Change-Id: Icd9402aec8a55c613c8fa12e917bf3fd63272271 BUG= TEST=Ran it and saw minimums change. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9fe00b9

Patch Set 1 #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	image_to_vm.sh	View		1 chunk	+4 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 2 months ago (2010-10-22 19:33:23 UTC) #2

LGTM

http://codereview.chromium.org/3956005/diff/1/2
File image_to_vm.sh (right):

http://codereview.chromium.org/3956005/diff/1/2#newcode69
image_to_vm.sh:69: warn "Disk is too small for full, using minimu:  vdisk size
equal to \
minimum

Expand Messages | Collapse Messages