base/lazy_instance.cc - Issue 3956003: ThreadRestrictions: leak the thread local variable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/lazy_instance.cc

Issue 3956003: ThreadRestrictions: leak the thread local variable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: better impl Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/lazy_instance.cc

diff --git a/base/lazy_instance.cc b/base/lazy_instance.cc

index 957482cbb2addd2815e857dea44e62748d13a24a..eb710615e313de397b312848393f97f99b33b2ee 100644

--- a/base/lazy_instance.cc

+++ b/base/lazy_instance.cc

@@ -37,7 +37,8 @@ void LazyInstanceHelper::CompleteInstance(void* instance, void (*dtor)(void*)) {

base::subtle::Release_Store(&state_, STATE_CREATED);

// Make sure that the lazily instantiated object will get destroyed at exit.

- base::AtExitManager::RegisterCallback(dtor, instance);

+ if (dtor)

+ base::AtExitManager::RegisterCallback(dtor, instance);

}

} // namespace base