- Add a presubmit check that lints C++ files (will submit CLs that...

- Add a presubmit check that lints C++ files (will submit CLs that
  add this to PRESUBMIT.py in the chromium tree later).
- Update cpplint.py to the latest version from the style guide.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32180

[M-A Ruel, 2009-11-16 21:27:11]

http://codereview.chromium.org/395022/diff/1/2
File presubmit_canned_checks.py (right):

http://codereview.chromium.org/395022/diff/1/2#newcode8
Line 8: import re
Please use input_api.re instead. Note there is no import in this file. :)

http://codereview.chromium.org/395022/diff/1/2#newcode80
Line 80: _RE_IS_TEST = re.compile(r'.*tests?.(cc|h)$')
Move this inside the function.

In theory, source_file_filter already filters out non-source file but it's
really broad and includes non-C++ files. Not a big deal.

You forgot .inl files.

http://codereview.chromium.org/395022/diff/1/2#newcode112
Line 112: cpplint.ProcessFile(file_name, 4)
Can you quick comment what '4' and '5' mean?

http://codereview.chromium.org/395022/diff/1/2#newcode118
Line 118: res_type = output_api.PresubmitError
I'd recommend a warning instead.

[Elliot Glaysher, 2009-11-16 22:08:18]

http://codereview.chromium.org/395022/diff/1/2
File presubmit_canned_checks.py (right):

http://codereview.chromium.org/395022/diff/1/2#newcode80
Line 80: _RE_IS_TEST = re.compile(r'.*tests?.(cc|h)$')
On 2009/11/16 21:27:11, Marc-Antoine Ruel wrote:
> Move this inside the function.

Done.

> In theory, source_file_filter already filters out non-source file but it's
> really broad and includes non-C++ files. Not a big deal.

cpplint.py barfs hard on Objective-C code; it was deliberate on my part. There's
further filtering in the PRESUBMIT.py to disallow any header from the cocoa
directory, or any header file with "_mac.h" in the name.
 
> You forgot .inl files.

The "-inl.h" files are filtered out in my local PRESUBMIT.py check (which is
next once this has been submitted) because the 3 inl.h headers use totally crazy
template tricks that cpplint will never be able to parse.

[M-A Ruel, 2009-11-17 01:59:42]

lgtm as-is or you can implement the nit if you want, I think the code would be
better with that.

Sorry for the delay.

http://codereview.chromium.org/395022/diff/5001/4004
File presubmit_canned_checks.py (right):

http://codereview.chromium.org/395022/diff/5001/4004#newcode87
Line 87: for affected_file in input_api.AffectedSourceFiles(source_file_filter):
nit: Do you mind just using one array and do the check only around line 114?
e.g.
files = [f.AbsoluteLocalPath() for f in
input_api.AffectedSourceFiles(source_file_filter)]

for filename in files:
  if RE_IS_TEST.match(filename):
    level = 5
  else:
    level = 4
  cpplint.ProcessFile(filename, level)

The reason is that it doesn't reorder arbitrarily the files.