Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 395013: Add DebugMessageDispatchHandler (Closed)

Created:
11 years, 1 month ago by ry
Modified:
9 years, 7 months ago
Reviewers:
Søren Thygesen Gjesse, søren gjesse <sgjesse
CC:
v8-dev
Visibility:
Public.

Description

Add DebugMessageDispatchHandler A callback on the debugger thread when a message is received. Allows the embedding application to wake up the main thread in order to handle the message. Useful when the embedding application is idle and sitting in a select() call. Committed: http://code.google.com/p/v8/source/detail?r=3326

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -0 lines) Patch
M include/v8-debug.h View 2 chunks +17 lines, -0 lines 1 comment Download
M src/api.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/debug.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/debug.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +64 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
ry
Hi Søren, Here is your DebugMessageDispatchHandler patch. I added a little test. It's working for ...
11 years, 1 month ago (2009-11-14 15:00:01 UTC) #1
Søren Thygesen Gjesse
LGTM, thanks for the patch. I will address the comments below when landing the patch. ...
11 years, 1 month ago (2009-11-18 08:40:57 UTC) #2
Søren Thygesen Gjesse
11 years, 1 month ago (2009-11-18 09:00:42 UTC) #3
On 2009/11/18 08:40:57, Søren Gjesse wrote:
> LGTM, thanks for the patch. I will address the comments below when landing the
> patch.
> 
> http://codereview.chromium.org/395013/diff/1/2
> File include/v8-debug.h (right):
> 
> http://codereview.chromium.org/395013/diff/1/2#newcode221
> Line 221: * received and is ready to be precessed. For the debug messages to
be
> precessed -> processed
> 
> http://codereview.chromium.org/395013/diff/1/6
> File test/cctest/test-debug.cc (right):
> 
> http://codereview.chromium.org/395013/diff/1/6#newcode4748
> Line 4748: debug_message_dispatch_barriers =
> &stack_allocated_debug_message_dispatch_barriers;
> Long line.

Committed as r3326.

Powered by Google App Engine
This is Rietveld 408576698