Issue 3941001: Convert LOG(INFO) to VLOG(1) - chrome/common/.

Issue 3941001: Convert LOG(INFO) to VLOG(1) - chrome/common/. (Closed)

Created:
10 years, 2 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, cbentzel+watch_chromium.org, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Convert LOG(INFO) to VLOG(1) - chrome/common/. This also removes LOG_RESOURCE_REQUESTS and all associated code. Also remove some "using"s, fix non-const ref (style violation), remove some "else" after "return", and remove some extra {}s. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63462

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -122 lines)			Patch
M	chrome/common/chrome_plugin_lib.cc	View		4 chunks	+6 lines, -7 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/deprecated/event_sys_unittest.cc	View	1	7 chunks	+16 lines, -22 lines	0 comments	Download
M	chrome/common/extensions/extension_file_util.cc	View		4 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/common/extensions/extension_unpacker.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/metrics_helpers.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/common/net/gaia/gaia_authenticator2.cc	View		5 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/common/notification_service.cc	View		3 chunks	+4 lines, -9 lines	0 comments	Download
M	chrome/common/resource_dispatcher.cc	View	1 2 3	14 chunks	+1 line, -47 lines	1 comment	Download
M	chrome/common/sandbox_policy.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/service_process_util_posix.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/socket_stream_dispatcher.cc	View		8 chunks	+15 lines, -16 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

http://codereview.chromium.org/3941001/diff/36001/37009 File chrome/common/resource_dispatcher.cc (left): http://codereview.chromium.org/3941001/diff/36001/37009#oldcode424 chrome/common/resource_dispatcher.cc:424: request_info->peer->GetURLForDebugging().possibly_invalid_spec()); we can probably delete GetURLForDebugging() now.

10 years, 2 months ago (2010-10-21 23:31:02 UTC) #3

Peter Kasting

On 2010/10/21 23:31:02, darin wrote: > http://codereview.chromium.org/3941001/diff/36001/37009 > File chrome/common/resource_dispatcher.cc (left): > > http://codereview.chromium.org/3941001/diff/36001/37009#oldcode424 > ...

10 years, 2 months ago (2010-10-22 00:55:23 UTC) #5

darin (slow to review)

10 years, 2 months ago (2010-10-22 06:01:27 UTC) #6

OK

On Thu, Oct 21, 2010 at 5:55 PM, <pkasting@chromium.org> wrote:

> On 2010/10/21 23:31:02, darin wrote:
>
>> http://codereview.chromium.org/3941001/diff/36001/37009
>> File chrome/common/resource_dispatcher.cc (left):
>>
>
>  http://codereview.chromium.org/3941001/diff/36001/37009#oldcode424
>> chrome/common/resource_dispatcher.cc:424:
>> request_info->peer->GetURLForDebugging().possibly_invalid_spec());
>> we can probably delete GetURLForDebugging() now.
>>
>
> Removing this is nontrivial, so I'm splitting it into a separate CL.
>
>
> http://codereview.chromium.org/3941001/show
>

Expand Messages | Collapse Messages