Issue 394007: * Remove old snapshot implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 394007: * Remove old snapshot implementation (Closed)

Created:
11 years, 1 month ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

* Remove old snapshot implementation

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -1844 lines)			Patch
M	SConstruct	View		1 chunk	+1 line, -1 line	1 comment	Download
M	src/api.cc	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	src/assembler.h	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/checks.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/globals.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/mksnapshot.cc	View		3 chunks	+7 lines, -91 lines	0 comments	Download
M	src/serialize.h	View	1	10 chunks	+30 lines, -271 lines	0 comments	Download
M	src/serialize.cc	View	1	25 chunks	+33 lines, -1319 lines	1 comment	Download
M	src/snapshot.h	View		2 chunks	+0 lines, -3 lines	0 comments	Download
M	src/snapshot-common.cc	View		3 chunks	+5 lines, -41 lines	0 comments	Download
M	src/v8.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	src/v8.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	test/cctest/cctest.status	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	test/cctest/test-serialize.cc	View		4 chunks	+4 lines, -101 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

11 years, 1 month ago (2009-11-13 13:43:36 UTC) #3

Whoops, I meant: stv!

http://codereview.chromium.org/394007/diff/5001/5015
File SConstruct (right):

http://codereview.chromium.org/394007/diff/5001/5015#newcode130
Line 130: 'CCFLAGS':      ['-O0', '-g', '-fomit-frame-pointer',
'-fdata-sections',
Ahem.

http://codereview.chromium.org/394007/diff/5001/5013
File src/serialize.cc (right):

http://codereview.chromium.org/394007/diff/5001/5013#newcode822
Line 822: CHECK(data == SYNCHRONIZE);
Why is this not an ASSERT?   Also CHECK_EQ?

http://codereview.chromium.org/394007/diff/5001/5002
File test/cctest/test-serialize.cc (left):

http://codereview.chromium.org/394007/diff/5001/5002#oldcode177
Line 177: #ifdef DEBUG
We have corresponding tests for the new serializer right?

Expand Messages | Collapse Messages