Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: Source/platform/heap/Visitor.cpp

Issue 393823003: Revert "Revert "[oilpan]: Make thread shutdown more robust."" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/platform/heap/Visitor.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 25 matching lines...) Expand all
36 36
37 namespace WebCore { 37 namespace WebCore {
38 38
39 #ifndef NDEBUG 39 #ifndef NDEBUG
40 void Visitor::checkGCInfo(const void* payload, const GCInfo* gcInfo) 40 void Visitor::checkGCInfo(const void* payload, const GCInfo* gcInfo)
41 { 41 {
42 FinalizedHeapObjectHeader::fromPayload(payload)->checkHeader(); 42 FinalizedHeapObjectHeader::fromPayload(payload)->checkHeader();
43 #if !defined(COMPONENT_BUILD) 43 #if !defined(COMPONENT_BUILD)
44 // On component builds we cannot compare the gcInfos as they are statically 44 // On component builds we cannot compare the gcInfos as they are statically
45 // defined in each of the components and hence will not match. 45 // defined in each of the components and hence will not match.
46 ASSERT(FinalizedHeapObjectHeader::fromPayload(payload)->gcInfo() == gcInfo); 46 BaseHeapPage* page = pageHeaderFromObject(payload);
47 ASSERT(page->orphaned() || FinalizedHeapObjectHeader::fromPayload(payload)-> gcInfo() == gcInfo);
47 #endif 48 #endif
48 } 49 }
49 50
50 #define DEFINE_VISITOR_CHECK_MARKER(Type) \ 51 #define DEFINE_VISITOR_CHECK_MARKER(Type) \
51 void Visitor::checkGCInfo(const Type* payload, const GCInfo* gcInfo) \ 52 void Visitor::checkGCInfo(const Type* payload, const GCInfo* gcInfo) \
52 { \ 53 { \
53 HeapObjectHeader::fromPayload(payload)->checkHeader(); \ 54 HeapObjectHeader::fromPayload(payload)->checkHeader(); \
54 Type* object = const_cast<Type*>(payload); \ 55 Type* object = const_cast<Type*>(payload); \
55 Address addr = pageHeaderAddress(reinterpret_cast<Address>(object)); \ 56 BaseHeapPage* page = pageHeaderFromObject(object); \
56 BaseHeapPage* page = reinterpret_cast<BaseHeapPage*>(addr); \ 57 ASSERT(page->orphaned() || page->gcInfo() == gcInfo); \
57 ASSERT(page->gcInfo() == gcInfo); \
58 } 58 }
59 59
60 FOR_EACH_TYPED_HEAP(DEFINE_VISITOR_CHECK_MARKER) 60 FOR_EACH_TYPED_HEAP(DEFINE_VISITOR_CHECK_MARKER)
61 #undef DEFINE_VISITOR_CHECK_MARKER 61 #undef DEFINE_VISITOR_CHECK_MARKER
62 #endif 62 #endif
63 63
64 } 64 }
OLDNEW
« no previous file with comments | « Source/platform/heap/Visitor.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698