Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 3936001: kernel cmdline: add dm_verity.dev_wait=1 (Closed)

Created:
10 years, 2 months ago by Will Drewry
Modified:
9 years, 7 months ago
Reviewers:
Nick Sanders
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

kernel cmdline: add dm_verity.dev_wait=1 dm_verity will wait for a device to be ready. This is needed in the factory installer so that dmsetup doesn't fail early before the usb device is visible. TEST=built images and booted them (x86-generic & factory installer) Prior to commit, need to ensure dev_wait doesn't break unverified boot behavior BUG=chromium-os:7451 Change-Id: I5b838b94e6a17dd0778331121311cdfe180991ce

Patch Set 1 #

Patch Set 2 : dev_wait blocks non-vboot; retesting images now #

Patch Set 3 : drop accidental inclusion! #

Patch Set 4 : fix use of non-existent flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M build_kernel_image.sh View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M create_legacy_bootloader_templates.sh View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Will Drewry
10 years, 2 months ago (2010-10-19 23:58:42 UTC) #1
Nick Sanders
lgtm, assuming tests all pass.
10 years, 2 months ago (2010-10-20 04:41:00 UTC) #2
Will Drewry
10 years, 2 months ago (2010-10-20 19:44:38 UTC) #3
tests passed, but I ended up tweaking it so that dev_wait is only =1 when rootfs
verification is enabled.  (Built with it enabled and disabled and
factory_install)

Now just investigating some switch_root weirdness prior to committing.

Cheers!
will

Powered by Google App Engine
This is Rietveld 408576698