Issue 3935001: Rename CommandLine::ARGUMENTS_ONLY to NO_PROGRAM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3935001: Rename CommandLine::ARGUMENTS_ONLY to NO_PROGRAM. (Closed)

Created:
10 years, 2 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Rename CommandLine::ARGUMENTS_ONLY to NO_PROGRAM. ARGUMENTS_ONLY was misleading since CommandLine has methods for handling "switches" and "arguments", but that constructor still allows both. BUG=none TEST=still builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63325

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -41 lines)			Patch
M	base/command_line.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	base/command_line.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/app/chrome_main_uitest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/about_flags_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/app_controller_mac.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/background_contents_service_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/background_mode_manager_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/browser_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/browser_init_browsertest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/diagnostics/diagnostics_model_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extensions_service_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/jumplist_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/prefs/command_line_pref_store_unittest.cc	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/prefs/pref_service_unittest.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/process_singleton_uitest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/safe_browsing/render_view_fake_resources_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/service/service_process_unittest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/test/automation/automation_proxy_uitest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/render_view_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/startup/startup_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/ui/ui_test.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM (be sure base_unittests still passes)

Expand Messages | Collapse Messages