Issue 39342: Refactor some source position info

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 39342: Refactor some source position info (Closed)

Created:
11 years, 9 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Changed a function in the internal debugger JavaScript to return the full source location instead of only the position. Added an optional parameter to exclude/include the source line offset in source location. Extended a message test to include a test with source offset. Committed: http://code.google.com/p/v8/source/detail?r=1461

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -40 lines)			Patch
M	src/debug-delay.js	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	src/messages.js	View	5 chunks	+12 lines, -7 lines	0 comments	Download
M	test/cctest/test-api.cc	View	2 chunks	+38 lines, -17 lines	0 comments	Download
M	test/mjsunit/debug-sourceinfo.js	View	1 chunk	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

This change is mainly to support an upcoming change and keep the size of that ...

11 years, 9 months ago (2009-03-09 15:10:53 UTC) #1

LGTM

Expand Messages | Collapse Messages