Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Issue 39331: Fix issue 263:... (Closed)

Created:
11 years, 9 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Fix issue 263: http://code.google.com/p/v8/issues/detail?id=263 Sharing the code to unlink the exception handler for a try/finally causes us to try to merge virtual frames with different heights (due to statements that keep state on the stack) at the entry to the unlink code. Avoid this by unlinking the handler separately for each exit from the try block. Committed: http://code.google.com/p/v8/source/detail?r=1449

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -83 lines) Patch
M src/codegen-arm.cc View 1 5 chunks +53 lines, -44 lines 0 comments Download
M src/codegen-ia32.cc View 5 chunks +46 lines, -39 lines 0 comments Download
A test/mjsunit/regress/regress-263.js View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 9 months ago (2009-03-09 10:31:17 UTC) #1
Kasper Lund
11 years, 9 months ago (2009-03-09 10:38:04 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698