Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 39322: Mark special internal scripts as native scripts (Closed)

Created:
11 years, 9 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Mark the empty script object, the script for the empty function and the D8 utility script as native scripts. This is mainly to avoid these scripts showing up in the debugger when showing normal scripts. Removed the check for the empty script in the debugger function returning loaded scripts as this check only filtered out the empty script from the debugger context and not empty scripts in all other contexts. Also this filter did not take the script for the empty function into account. Committed: http://code.google.com/p/v8/source/detail?r=1443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M src/bootstrapper.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/d8.cc View 1 chunk +9 lines, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -5 lines 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 9 months ago (2009-03-08 16:29:02 UTC) #1
Mads Ager (chromium)
11 years, 9 months ago (2009-03-09 08:35:27 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698