Snapshotting progress....

Snapshotting progress.
Got app and unit_tests linking with gyp under windows.
Still missing pieces (things don't run).


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11302

[Mark Mentovai, 2009-03-08 04:08:13]

Happy to hear of your progress, Brad.  Just a few organizational concerns.

http://codereview.chromium.org/39319/diff/1/6
File chrome/chrome.gyp (right):

http://codereview.chromium.org/39319/diff/1/6#newcode1398
Line 1398: 'worker/webworkerclient_proxy.cc',
These aren't part of the app.vcproj in the existing system, is there a better
place for them than this target?

http://codereview.chromium.org/39319/diff/1/6#newcode1463
Line 1463: '../third_party/WebKit/WebKit/chromium/public',
Ah, well this is because app doesn't depend on webkit.  Wherever the worker
stuff winds up, we should just make that target depend on webkit to leverage the
power of dependent settings.

http://codereview.chromium.org/39319/diff/1/6#newcode1848
Line 1848: 'test/test_tab_contents.cc',
The test/ portion of this list could use some sorting TLC

http://codereview.chromium.org/39319/diff/1/6#newcode1937
Line 1937: 'test/test_tab_contents.cc',
Ditto

http://codereview.chromium.org/39319/diff/1/3
File third_party/zlib/zlib.gyp (right):

http://codereview.chromium.org/39319/diff/1/3#newcode16
Line 16: 'contrib/minizip/iowin32.c',
Oh wow, oops!  Surprised nobody caught this before now.

[bradn, 2009-03-08 04:43:35]

http://codereview.chromium.org/39319/diff/1/6
File chrome/chrome.gyp (right):

http://codereview.chromium.org/39319/diff/1/6#newcode1398
Line 1398: 'worker/webworkerclient_proxy.cc',
On 2009/03/08 04:08:13, Mark Mentovai wrote:
> These aren't part of the app.vcproj in the existing system, is there a better
> place for them than this target?

Good point. Moved these to a worker target to match the vcproj files.

http://codereview.chromium.org/39319/diff/1/6#newcode1463
Line 1463: '../third_party/WebKit/WebKit/chromium/public',
On 2009/03/08 04:08:13, Mark Mentovai wrote:
> Ah, well this is because app doesn't depend on webkit.  Wherever the worker
> stuff winds up, we should just make that target depend on webkit to leverage
the
> power of dependent settings.

Done.

http://codereview.chromium.org/39319/diff/1/6#newcode1848
Line 1848: 'test/test_tab_contents.cc',
On 2009/03/08 04:08:13, Mark Mentovai wrote:
> The test/ portion of this list could use some sorting TLC

Done.

http://codereview.chromium.org/39319/diff/1/6#newcode1937
Line 1937: 'test/test_tab_contents.cc',
On 2009/03/08 04:08:13, Mark Mentovai wrote:
> Ditto

Done.

http://codereview.chromium.org/39319/diff/1/3
File third_party/zlib/zlib.gyp (right):

http://codereview.chromium.org/39319/diff/1/3#newcode16
Line 16: 'contrib/minizip/iowin32.c',
On 2009/03/08 04:08:13, Mark Mentovai wrote:
> Oh wow, oops!  Surprised nobody caught this before now.

Yeah no kidding!

[Mark Mentovai, 2009-03-09 03:33:58]

LGTM with one change if it passes the Mac try bot.

http://codereview.chromium.org/39319/diff/1008/1013
File chrome/chrome.gyp (right):

http://codereview.chromium.org/39319/diff/1008/1013#newcode1454
Line 1454: '../third_party/WebKit/WebKit/chromium/public',
No longer applicable, take this out?