Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 393009: Improve the allocation and initialization of locals on IA32 in the top-level ... (Closed)

Created:
11 years, 1 month ago by fschneider
Modified:
9 years, 6 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Improve the allocation and initialization of locals on IA32 in the top-level compiler. This optimization is already done on x64 and ARM. Until now we used a push immediate for each local variable on IA32: push $undefined push $undefined ... to initialize each local variable. This change does: mov eax, $undefined push eax push eax ... Committed: http://code.google.com/p/v8/source/detail?r=3304

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/ia32/fast-codegen-ia32.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
This optimization was missing on IA32.
11 years, 1 month ago (2009-11-13 12:12:11 UTC) #1
William Hesse
11 years, 1 month ago (2009-11-13 12:13:39 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698