Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(337)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Issue
393001
: Split scm-specific functions out of gclient_scm.py to scm.py. (Closed)
Created:
11 years, 1 month ago by
M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.
Description
Split scm-specific functions out of gclient_scm.py to scm.py. Reapplies r31809 is typo fixed. TEST=unit tests fixed and reclassified BUG=none
Patch Set 1
#
Created:
11 years, 1 month ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+683 lines, -548 lines
)
Patch
M
PRESUBMIT.py
View
1 chunk
+2 lines, -0 lines
0 comments
Download
M
gclient_scm.py
View
3 chunks
+5 lines, -323 lines
0 comments
Download
A
scm.py
View
1 chunk
+336 lines, -0 lines
0 comments
Download
M
tests/gclient_scm_test.py
View
3 chunks
+1 line, -119 lines
0 comments
Download
M
tests/gclient_test.py
View
3 chunks
+7 lines, -106 lines
0 comments
Download
A
tests/gclient_utils_test.py
View
1 chunk
+53 lines, -0 lines
0 comments
Download
A
tests/scm_unittest.py
View
1 chunk
+279 lines, -0 lines
0 comments
Download
Messages
Total messages: 2 (0 generated)
Expand Messages
|
Collapse Messages
M-A Ruel
11 years, 1 month ago (2009-11-12 19:42:27 UTC)
#1
Dirk Pranke
lgtm (no obvious typos)
11 years, 1 month ago (2009-11-12 19:47:16 UTC)
#2
lgtm (no obvious typos)
Expand Messages
|
Collapse Messages
Issue 393001: Split scm-specific functions out of gclient_scm.py to scm.py. (Closed)
Created 11 years, 1 month ago by M-A Ruel
Modified 9 years, 7 months ago
Reviewers: Dirk Pranke
Base URL:
Comments: 0
This is Rietveld
408576698