Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: src/x64/macro-assembler-x64.h

Issue 3928002: Update x64 RecordWrite comment. When the offset is zero the index... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 template <typename LabelType> 94 template <typename LabelType>
95 void InNewSpace(Register object, 95 void InNewSpace(Register object,
96 Register scratch, 96 Register scratch,
97 Condition cc, 97 Condition cc,
98 LabelType* branch); 98 LabelType* branch);
99 99
100 // For page containing |object| mark region covering [object+offset] 100 // For page containing |object| mark region covering [object+offset]
101 // dirty. |object| is the object being stored into, |value| is the 101 // dirty. |object| is the object being stored into, |value| is the
102 // object being stored. If |offset| is zero, then the |scratch| 102 // object being stored. If |offset| is zero, then the |scratch|
103 // register contains the array index into the elements array 103 // register contains the array index into the elements array
104 // represented as a Smi. All registers are clobbered by the 104 // represented as an untagged 32-bit integer. All registers are
105 // operation. RecordWrite filters out smis so it does not update the 105 // clobbered by the operation. RecordWrite filters out smis so it
106 // write barrier if the value is a smi. 106 // does not update the write barrier if the value is a smi.
107 void RecordWrite(Register object, 107 void RecordWrite(Register object,
108 int offset, 108 int offset,
109 Register value, 109 Register value,
110 Register scratch); 110 Register scratch);
111 111
112 // For page containing |object| mark region covering [address] 112 // For page containing |object| mark region covering [address]
113 // dirty. |object| is the object being stored into, |value| is the 113 // dirty. |object| is the object being stored into, |value| is the
114 // object being stored. All registers are clobbered by the 114 // object being stored. All registers are clobbered by the
115 // operation. RecordWrite filters out smis so it does not update 115 // operation. RecordWrite filters out smis so it does not update
116 // the write barrier if the value is a smi. 116 // the write barrier if the value is a smi.
117 void RecordWrite(Register object, 117 void RecordWrite(Register object,
118 Register address, 118 Register address,
119 Register value); 119 Register value);
120 120
121 // For page containing |object| mark region covering [object+offset] dirty. 121 // For page containing |object| mark region covering [object+offset] dirty.
122 // The value is known to not be a smi. 122 // The value is known to not be a smi.
123 // object is the object being stored into, value is the object being stored. 123 // object is the object being stored into, value is the object being stored.
124 // If offset is zero, then the scratch register contains the array index into 124 // If offset is zero, then the scratch register contains the array index into
125 // the elements array represented as a Smi. 125 // the elements array represented as an untagged 32-bit integer.
126 // All registers are clobbered by the operation. 126 // All registers are clobbered by the operation.
127 void RecordWriteNonSmi(Register object, 127 void RecordWriteNonSmi(Register object,
128 int offset, 128 int offset,
129 Register value, 129 Register value,
130 Register scratch); 130 Register scratch);
131 131
132 #ifdef ENABLE_DEBUGGER_SUPPORT 132 #ifdef ENABLE_DEBUGGER_SUPPORT
133 // --------------------------------------------------------------------------- 133 // ---------------------------------------------------------------------------
134 // Debugger Support 134 // Debugger Support
135 135
(...skipping 1554 matching lines...) Expand 10 before | Expand all | Expand 10 after
1690 Jump(adaptor, RelocInfo::CODE_TARGET); 1690 Jump(adaptor, RelocInfo::CODE_TARGET);
1691 } 1691 }
1692 bind(&invoke); 1692 bind(&invoke);
1693 } 1693 }
1694 } 1694 }
1695 1695
1696 1696
1697 } } // namespace v8::internal 1697 } } // namespace v8::internal
1698 1698
1699 #endif // V8_X64_MACRO_ASSEMBLER_X64_H_ 1699 #endif // V8_X64_MACRO_ASSEMBLER_X64_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698