Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 39251: Fix issue 259.... (Closed)

Created:
11 years, 9 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Fix issue 259. http://code.google.com/p/v8/issues/detail?id=259 Due to constant folding of loop conditions, it is possible to have a try/finally with no exits from the try block (eg, an infinite loop in the try block). In that case the code to unlink the try handler is dead and should not be emitted. Committed: http://code.google.com/p/v8/source/detail?r=1434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -15 lines) Patch
M src/codegen-ia32.cc View 1 chunk +22 lines, -15 lines 0 comments Download
A test/mjsunit/regress/regress-259.js View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 9 months ago (2009-03-06 10:09:26 UTC) #1
Kasper Lund
11 years, 9 months ago (2009-03-06 10:12:37 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698