Issue 3922003: Add SendSignalWithNoArgumentsToSystemBus() to dbus.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3922003: Add SendSignalWithNoArgumentsToSystemBus() to dbus.h (Closed)

Created:
10 years, 2 months ago by satorux1

Modified:
9 years, 7 months ago

Reviewers:
oshima

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/common.git

Visibility:
Public.

Description

Add SendSignalWithNoArgumentsToSystemBus() to dbus.h The original code is from libcros's chromeos_screen_lock.cc. We should have this in a common place so we can use this from elsewhere. BUG=chromium-os:5763 BUG=chromium-os:6526 Change-Id: Ia703a18b2344013a01bc136d9c8d320a45c9dedc TEST=Confirmed that the screen locker works as before with this fucntion. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=295dee2

Patch Set 1 #

Patch Set 2 : fix the name #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -1 line)			Patch
	M	chromeos/dbus/dbus.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
	M	chromeos/dbus/dbus.cc	View	1	1 chunk	+23 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

oshima

forgot to ask. Didn't you change chromeos_screen_lock.cc as well? On 2010/10/20 04:59:46, oshima wrote: > ...

10 years, 2 months ago (2010-10-20 05:00:10 UTC) #3

satorux1

10 years, 2 months ago (2010-10-20 05:02:12 UTC) #4

chromeos_screen_lock.cc is in a separate repository. I'll send you a separate
code review .

On 2010/10/20 05:00:10, oshima wrote:
> forgot to ask. Didn't you change chromeos_screen_lock.cc as well?
> 
> On 2010/10/20 04:59:46, oshima wrote:
> > lgtm

Expand Messages | Collapse Messages