test_shell and test_shell_tests on Linux from gyp-generated scons files:

Build test_shell and test_shell_tests on Linux from gyp-generated scons files:
* Catch up to recent changes:
  * Rename RenderThemeChromiumGtk.cpp to RenderThemeChromiumLinux.cpp.
  * Fix spelling of V*NPObject.{cpp,h}
* Explicitly include varions WebCore *Gtk.cpp and *Linux.cpp files that
  are excluded by the general regular expression.
* Add webinput_event_util.cc.
* Exclude glue/plugins/plugin_stubs.cc.
* Add a Linux test_shell_resources target to build
  test_shell_resources.{h,pak}.
* Add an explicit test_shell action to repack resources into test_shell.pak.
* Use -Wno-multichar when building libtest_shell_common.a.
* Use -DWTF_USE_PTHREADS when building libwtf.a, and when dependent
  targets compile against it.
* Use tools/test_shell/test_shell_main{,_GYP}.scons as the main
  entry point for GYP-based builds of webkit.
* Add base/gfx/gtk_util.cc to the base build.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11160

[sgk, 2009-03-06 00:05:54]

Out for preliminary review while I try to figure out a segfault in the
gyp-generated test_shell_tests.

This shows the intended use for 'scons_depends'.  Let me know if you have a
better pattern for this.

[Mark Mentovai, 2009-03-06 00:32:49]

http://codereview.chromium.org/39219/diff/1001/1003
File webkit/tools/test_shell/test_shell.gyp (right):

http://codereview.chromium.org/39219/diff/1001/1003#newcode179
Line 179: 'scons_depends': [
I'm not sure what it means in SCons parlance for test_shell to "depend" on its
own executable.

When you say that test_shell has a scons_depend on test_shell.pak, what's that
for?  Is it supposed to force test_shell.pak to be generated?  If so, we should
probably make the scons generator do something more platform-neutral if
possible.  The Xcode and VS generators both run all actions when building a
target.  What would this take for SCons?  Would it be the equivalent of taking
each action output and implicitly adding a SCons depend for it?

http://codereview.chromium.org/39219/diff/1001/1002
File webkit/webkit.gyp (right):

http://codereview.chromium.org/39219/diff/1001/1002#newcode353
Line 353: 'defines': ['WTF_USE_PTHREADS=1'],
I see this being used in the webcore target too, implying that it's needed by at
least one of wtf's exported headers.  Perhaps instead of defining it there, we
should have it here and in an export_dependent_settings section here as well?

[sgk, 2009-03-06 21:26:24]

Linux test_shell and test_shell_tests both build from GYP-generated files with
this CL.  test_shell_tests fails execution, but I'd like to capture this
buildable state while working on fixing that.

http://codereview.chromium.org/39219/diff/1001/1003
File webkit/tools/test_shell/test_shell.gyp (right):

http://codereview.chromium.org/39219/diff/1001/1003#newcode179
Line 179: 'scons_depends': [
On 2009/03/06 00:32:49, Mark Mentovai wrote:
> I'm not sure what it means in SCons parlance for test_shell to "depend" on its
> own executable.
> 
> When you say that test_shell has a scons_depend on test_shell.pak, what's that
> for?  Is it supposed to force test_shell.pak to be generated?  If so, we
should
> probably make the scons generator do something more platform-neutral if
> possible.  The Xcode and VS generators both run all actions when building a
> target.  What would this take for SCons?  Would it be the equivalent of taking
> each action output and implicitly adding a SCons depend for it?

Overrun by having the gyp generator create env.Requires() calls for all actions.

http://codereview.chromium.org/39219/diff/1001/1002
File webkit/webkit.gyp (right):

http://codereview.chromium.org/39219/diff/1001/1002#newcode353
Line 353: 'defines': ['WTF_USE_PTHREADS=1'],
On 2009/03/06 00:32:49, Mark Mentovai wrote:
> I see this being used in the webcore target too, implying that it's needed by
at
> least one of wtf's exported headers.  Perhaps instead of defining it there, we
> should have it here and in an export_dependent_settings section here as well?

Done.

[Mark Mentovai, 2009-03-06 21:28:23]

Great! LGTM.