Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2620)

Unified Diff: base/file_descriptor_posix.h

Issue 39208: POSIX: Rewrite IPC's interaction with FileDescriptor (Closed)
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/file_descriptor_posix.h
diff --git a/base/file_descriptor_posix.h b/base/file_descriptor_posix.h
index 8ebc5be59a96f2a73d8dea658900789cc59f0e8e..0bcd4b6c6955663a83a6727be2bfeab237d81ebd 100644
--- a/base/file_descriptor_posix.h
+++ b/base/file_descriptor_posix.h
@@ -10,6 +10,10 @@ namespace base {
// -----------------------------------------------------------------------------
// We introduct a special structure for file descriptors in order that we are
// able to use template specialisation to special-case their handling.
+//
+// WARNING: (Chromium only) There are subtleties to consider if serialising
+// these objects over IPC. See comments in chrome/common/ipc_message_utils.h
+// above the template specialisation for this structure.
// -----------------------------------------------------------------------------
struct FileDescriptor {
FileDescriptor()
« no previous file with comments | « no previous file | chrome/browser/renderer_host/render_widget_helper.h » ('j') | chrome/common/ipc_message_utils.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698