Enforce that only one constrained window is displayed at once per tab.

chrome/browser/login_prompt_gtk.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/login_prompt.h"
 
 #include <gtk/gtk.h>
 
 #include "app/l10n_util.h"
 #include "chrome/browser/chrome_thread.h"
@@ skipping 88 matching lines @@
         l10n_util::GetStringUTF8(IDS_LOGIN_DIALOG_USERNAME_FIELD).c_str(),
         username_entry_,
         l10n_util::GetStringUTF8(IDS_LOGIN_DIALOG_PASSWORD_FIELD).c_str(),
         password_entry_,
         NULL);
     gtk_box_pack_start(GTK_BOX(root_.get()), table, FALSE, FALSE, 0);
 
     GtkWidget* hbox = gtk_hbox_new(FALSE, 12);
     gtk_box_pack_start(GTK_BOX(root_.get()), hbox, FALSE, FALSE, 0);
 
-    GtkWidget* ok = gtk_button_new_from_stock(GTK_STOCK_OK);
+    ok_ = gtk_button_new_from_stock(GTK_STOCK_OK);
     gtk_button_set_label(
-        GTK_BUTTON(ok),
+        GTK_BUTTON(ok_),
         l10n_util::GetStringUTF8(IDS_LOGIN_DIALOG_OK_BUTTON_LABEL).c_str());
-    g_signal_connect(ok, "clicked", G_CALLBACK(OnOKClicked), this);
-    gtk_box_pack_end(GTK_BOX(hbox), ok, FALSE, FALSE, 0);
+    g_signal_connect(ok_, "clicked", G_CALLBACK(OnOKClicked), this);
+    gtk_box_pack_end(GTK_BOX(hbox), ok_, FALSE, FALSE, 0);
 
     GtkWidget* cancel = gtk_button_new_from_stock(GTK_STOCK_CANCEL);
     g_signal_connect(cancel, "clicked", G_CALLBACK(OnCancelClicked), this);
     gtk_box_pack_end(GTK_BOX(hbox), cancel, FALSE, FALSE, 0);
 
+    g_signal_connect(root_.get(), "hierarchy-changed",
+                     G_CALLBACK(OnPromptShown), this);
+
     SetModel(manager);
 
     // Scary thread safety note: This can potentially be called *after* SetAuth
     // or CancelAuth (say, if the request was cancelled before the UI thread got
     // control).  However, that's OK since any UI interaction in those functions
     // will occur via an InvokeLater on the UI thread, which is guaranteed
     // to happen after this is called (since this was InvokeLater'd first).
     dialog_ = GetTabContentsForLogin()->CreateConstrainedDialog(this);
 
-    // Now that we have attached ourself to the window, we can make our OK
-    // button the default action and mess with the focus.
-    GTK_WIDGET_SET_FLAGS(ok, GTK_CAN_DEFAULT);
-    gtk_widget_grab_default(ok);
-    gtk_widget_grab_focus(username_entry_);
-
     SendNotifications();
   }
 
   virtual void SetPasswordForm(const webkit_glue::PasswordForm& form) {
     password_form_ = form;
   }
 
   virtual void SetPasswordManager(PasswordManager* password_manager) {
     password_manager_ = password_manager;
   }
@@ skipping 138 matching lines @@
       service->Notify(NotificationType::AUTH_NEEDED,
                       Source<NavigationController>(controller),
                       Details<LoginNotificationDetails>(&details));
     } else {
       service->Notify(NotificationType::AUTH_SUPPLIED,
                       Source<NavigationController>(controller),
                       NotificationService::NoDetails());
     }
   }
 
-  static void OnOKClicked(GtkButton *button, LoginHandlerGtk* handler) {
+  static void OnOKClicked(GtkButton* button, LoginHandlerGtk* handler) {
     DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI));
 
     handler->SetAuth(
         UTF8ToWide(gtk_entry_get_text(GTK_ENTRY(handler->username_entry_))),
         UTF8ToWide(gtk_entry_get_text(GTK_ENTRY(handler->password_entry_))));
   }
 
-  static void OnCancelClicked(GtkButton *button, LoginHandlerGtk* handler) {
+  static void OnCancelClicked(GtkButton* button, LoginHandlerGtk* handler) {
     DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI));
     handler->CancelAuth();
   }
 
+  static void OnPromptShown(GtkButton* root,
+                            GtkWidget* previous_toplevel,
+                            LoginHandlerGtk* handler) {
+    DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI));
+    if (!GTK_WIDGET_TOPLEVEL(gtk_widget_get_toplevel(handler->ok_)))
+      return;
+
+    // Now that we have attached ourself to the window, we can make our OK
+    // button the default action and mess with the focus.
+    GTK_WIDGET_SET_FLAGS(handler->ok_, GTK_CAN_DEFAULT);
+    gtk_widget_grab_default(handler->ok_);
+    gtk_widget_grab_focus(handler->username_entry_);
+  }
+
   // True if we've handled auth (SetAuth or CancelAuth has been called).
   bool handled_auth_;
   Lock handled_auth_lock_;
 
   // The ConstrainedWindow that is hosting our LoginView.
   // This should only be accessed on the UI loop.
   ConstrainedWindow* dialog_;
 
   // The request that wants login data.
   // This should only be accessed on the IO loop.
@@ skipping 13 matching lines @@
   // Cached from the URLRequest, in case it goes NULL on us.
   int render_process_host_id_;
   int tab_contents_id_;
 
   // The GtkWidgets that form our visual hierarchy:
   // The root container we pass to our parent.
   OwnedWidgetGtk root_;
 
   // GtkEntry widgets that the user types into.
   GtkWidget* username_entry_;
+  GtkWidget* ok_;
   GtkWidget* password_entry_;
 
   // If not null, points to a model we need to notify of our own destruction
   // so it doesn't try and access this when its too late.
   LoginModel* login_model_;
 
   DISALLOW_COPY_AND_ASSIGN(LoginHandlerGtk);
 };
 
 // static
 LoginHandler* LoginHandler::Create(URLRequest* request) {
   return new LoginHandlerGtk(request);
 }