Issue 392006: Cleanup the unit tests by mocking more system functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 392006: Cleanup the unit tests by mocking more system functions. (Closed)

Created:
11 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Cleanup the unit tests by mocking more system functions. TEST=unit tests BUG=none

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+226 lines, -180 lines)			Patch
M	tests/gcl_unittest.py	View	4 chunks	+6 lines, -17 lines	0 comments	Download
M	tests/gclient_scm_test.py	View	24 chunks	+95 lines, -70 lines	0 comments	Download
M	tests/gclient_test.py	View	5 chunks	+5 lines, -26 lines	0 comments	Download
M	tests/presubmit_unittest.py	View	7 chunks	+12 lines, -29 lines	0 comments	Download
M	tests/revert_unittest.py	View	3 chunks	+11 lines, -16 lines	0 comments	Download
M	tests/super_mox.py	View	2 chunks	+79 lines, -2 lines	0 comments	Download
M	tests/trychange_unittest.py	View	4 chunks	+14 lines, -15 lines	0 comments	Download
M	tests/watchlists_unittest.py	View	3 chunks	+4 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Dirk Pranke

lgtm. I think I'm going to learn pymox solely through reviewing your patches ...

11 years, 1 month ago (2009-11-12 01:59:14 UTC) #2

M-A Ruel

11 years, 1 month ago (2009-11-12 02:04:40 UTC) #3

On 2009/11/12 01:59:14, dpranke wrote:
> lgtm. I think I'm going to learn pymox solely through reviewing your patches
...

That's the goal! :)