Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Issue 39186: Revert revisions 1383, 1384, 1391, 1398, 1401, 1402,... (Closed)

Created:
11 years, 9 months ago by Kasper Lund
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Revert revisions 1383, 1384, 1391, 1398, 1401, 1402, 1418, and 1419 from bleeding_edge until we have a fix for the crashers we see on the distributed test infra- structure. We know that revision 1383 is causing issues, but I had to revert some of the other recent RegExp changes in order to get this part out. Committed: http://code.google.com/p/v8/source/detail?r=1429

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -859 lines) Patch
M src/factory.h View 1 chunk +6 lines, -14 lines 0 comments Download
M src/factory.cc View 2 chunks +6 lines, -26 lines 0 comments Download
M src/jsregexp.h View 5 chunks +27 lines, -76 lines 0 comments Download
M src/jsregexp.cc View 16 chunks +254 lines, -332 lines 0 comments Download
M src/macros.py View 2 chunks +1 line, -20 lines 0 comments Download
M src/objects.h View 4 chunks +5 lines, -39 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +2 lines, -13 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/regexp-delay.js View 8 chunks +59 lines, -92 lines 0 comments Download
M src/runtime.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime.cc View 2 chunks +6 lines, -17 lines 0 comments Download
M src/string.js View 17 chunks +68 lines, -89 lines 0 comments Download
M test/mjsunit/regexp-static.js View 1 chunk +0 lines, -5 lines 0 comments Download
D test/mjsunit/regexp-string-methods.js View 1 chunk +0 lines, -51 lines 0 comments Download
D test/mjsunit/regress/regress-254.js View 1 chunk +0 lines, -58 lines 0 comments Download
M tools/js2c.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
This is actually quite annoying and kinda dramatic and it is not something we *need* ...
11 years, 9 months ago (2009-03-05 13:10:44 UTC) #1
Mads Ager (chromium)
11 years, 9 months ago (2009-03-05 13:21:30 UTC) #2
LGTM

If we cannot find the issue with revision 1389 today or tomorrow, I think we
need to do this so we can do some stress testing of the new compiler.

Powered by Google App Engine
This is Rietveld 408576698