src/codegen-ia32.cc - Issue 39184: Optimizing nested, constant object literals (like JSON objects) by building o...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codegen-ia32.cc

Issue 39184: Optimizing nested, constant object literals (like JSON objects) by building o... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 11 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/codegen-ia32.cc

===================================================================

--- src/codegen-ia32.cc (revision 1431)

+++ src/codegen-ia32.cc (working copy)

@@ -3432,7 +3432,10 @@

for (int i = 0; i < node->properties()->length(); i++) {

ObjectLiteral::Property* property = node->properties()->at(i);

switch (property->kind()) {

- case ObjectLiteral::Property::CONSTANT: break;

+ case ObjectLiteral::Property::CONSTANT:

+ break;

+ case ObjectLiteral::Property::OBJECT_LITERAL:

+ if (property->value()->AsObjectLiteral()->is_simple()) break;

case ObjectLiteral::Property::COMPUTED: {

Handle<Object> key(property->key()->handle());

Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Initialize));

« no previous file with comments | « src/ast.cc ('k') | src/parser.cc » ('j') | src/parser.cc » ('J')