Issue 3918001: Convert LOG(INFO) to VLOG(1) - tools/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3918001: Convert LOG(INFO) to VLOG(1) - tools/. (Closed)

Created:
10 years, 2 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Convert LOG(INFO) to VLOG(1) - tools/. This also fixes some lines over 80 chars, and converts a file to using the standard license header (I verified that the existing long-form license was exactly the same as the one in LICENSE). BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63149

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -46 lines)			Patch
	M	tools/memory_watcher/memory_watcher.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	M	tools/memory_watcher/preamble_patcher.cc	View		5 chunks	+12 lines, -43 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

10 years, 2 months ago (2010-10-19 22:17:23 UTC) #2

I'm not at all familiar with the pre-amble patcher.... but since all you're
doing is style fixes and VLOG, I'm willing to LGTM the whole lot.

Expand Messages | Collapse Messages